Make multipart parsing more forgiving: start-of-line and casing #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a multipart response i wanted to parse, and julia failed to parse it. These changes let it parse: 1. The content-disposition was the _second_ line in each part, with the content-type coming first, so the `^` was failing to parse. 2. The `content-type:` key was lower-cased, not Title-Cased as expected. Dunno if these are generally correct, but they worked in my case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 32 32
Lines 3058 3058
=======================================
Hits 2544 2544
Misses 514 514 ☔ View full report in Codecov by Sentry. |
quinnj
approved these changes
Apr 5, 2024
quinnj
approved these changes
Apr 6, 2024
|
Let me know if this is needed in a release (for 0.9 or 0.10), otherwise, I'll let is sit on master until a new release is needed. |
|
not needed; i was just trying to be a good citizen here and fix a bug I found. 😊 thanks! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a multipart response i wanted to parse, and julia failed to parse it. These changes let it parse:
^was failing to parse.content-type:key was lower-cased, not Title-Cased as expected.Dunno if these are generally correct, but they worked in my case.