Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket disconnection errors #723

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

tisztamo
Copy link
Contributor

Close #722

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2021

Codecov Report

Merging #723 (83b152a) into master (209f10e) will increase coverage by 0.57%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   76.29%   76.86%   +0.57%     
==========================================
  Files          37       37              
  Lines        2438     2442       +4     
==========================================
+ Hits         1860     1877      +17     
+ Misses        578      565      -13     
Impacted Files Coverage Δ
src/WebSockets.jl 84.82% <75.00%> (-0.49%) ⬇️
src/Handlers.jl 62.96% <0.00%> (+0.46%) ⬆️
src/ConnectionPool.jl 80.74% <0.00%> (+0.68%) ⬆️
src/sniff.jl 84.96% <0.00%> (+0.75%) ⬆️
src/StreamRequest.jl 95.45% <0.00%> (+1.51%) ⬆️
src/Servers.jl 86.25% <0.00%> (+1.87%) ⬆️
src/access_log.jl 93.22% <0.00%> (+3.38%) ⬆️
src/IOExtras.jl 81.25% <0.00%> (+6.25%) ⬆️
src/parseutils.jl 73.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209f10e...83b152a. Read the comment docs.

@quinnj
Copy link
Member

quinnj commented Jun 17, 2021

LGTM; thanks for the contribution!

@quinnj quinnj merged commit ffee0a0 into JuliaWeb:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while closing websocket
3 participants