-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hide IOErrors when remote closes the connection #727
Conversation
because these aren't actionable anyways
Should it be logged at |
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
=======================================
Coverage 76.87% 76.88%
=======================================
Files 37 37
Lines 2443 2444 +1
=======================================
+ Hits 1878 1879 +1
Misses 565 565
Continue to review full report at Codecov.
|
Makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, add a note in the changelog?
Wanna tag a new patch release, @fredrikekre? :) |
Was already working on it: #729 |
because these aren't actionable anyways.
Fixes #392.