Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide IOErrors when remote closes the connection #727

Merged
merged 4 commits into from
Jun 30, 2021

Conversation

pfitzseb
Copy link
Contributor

because these aren't actionable anyways.

Fixes #392.

because these aren't actionable anyways
@tanmaykm
Copy link
Member

Should it be logged at @debug or @info level instead of completely ignoring? I believe servers like nginx do log a "upstream prematurely closed connection" when this happens. May be there are situations when it would be useful to know that this happened at the server?

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #727 (a58b5c6) into master (6e0a60b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #727   +/-   ##
=======================================
  Coverage   76.87%   76.88%           
=======================================
  Files          37       37           
  Lines        2443     2444    +1     
=======================================
+ Hits         1878     1879    +1     
  Misses        565      565           
Impacted Files Coverage Δ
src/Servers.jl 86.33% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e0a60b...a58b5c6. Read the comment docs.

@pfitzseb
Copy link
Contributor Author

Makes sense.

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add a note in the changelog?

src/Servers.jl Show resolved Hide resolved
@fredrikekre fredrikekre requested a review from quinnj June 29, 2021 11:22
CHANGELOG.md Outdated Show resolved Hide resolved
@fredrikekre fredrikekre merged commit 2049674 into JuliaWeb:master Jun 30, 2021
@pfitzseb pfitzseb deleted the sp/no-ioerror branch June 30, 2021 08:11
@pfitzseb
Copy link
Contributor Author

Wanna tag a new patch release, @fredrikekre? :)

@fredrikekre
Copy link
Member

Was already working on it: #729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream is closed or unusable
4 participants