-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize Connections
to avoid type instabilities
#983
Conversation
Connections
to avoid type instabilitiesConnections
to avoid type instabilities
@quinnj re the CI test failure on MacOS... locally, when I try running the
and no report gets generated. I don't understand why would this start failing as a result of the changes introduced in this PR, though... any ideas? EDIT: Seems that the problem resolved itself |
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 82.56% 82.58% +0.01%
==========================================
Files 36 36
Lines 3023 3026 +3
==========================================
+ Hits 2496 2499 +3
Misses 527 527
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Connections
to avoid type instabilitiesConnections
to avoid type instabilities
Co-authored-by: Nick Robinson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Drvi; this looks great. I'm going to commit the one suggestion I made so we get one more CI run, but then I'll merge.
Is there a simple allocations test we can add for this PR, so we don't lose these gains over time? something along the lines of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an allocations-related test would be nice to have
otherwise looks great to me
I noticed that due to instabilities, all calls to
bytesavailable
were allocating forConnection
s due to theio
field being abstractly typed (IO
). Now these allocations are gone; a little parsing benchmark of a 500MB gzipped file: