Make timeouts default to 60 seconds #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client-side timeout implementation has gotten much more reliable and robust over the last little while. The reason we didn't include a timeout by default is that it wasn't in the past, but now I believe things are robust enough to set it and catch unresponsive servers for clients without waiting on the response indefinitely.
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 82.93% 82.84% -0.10%
==========================================
Files 37 37
Lines 3053 3054 +1
==========================================
- Hits 2532 2530 -2
- Misses 521 524 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client-side timeout implementation has gotten much more reliable and robust over the last little while. The reason we didn't include a timeout by default is that it wasn't in the past, but now I believe things are robust enough to set it and catch unresponsive servers for clients without waiting on the response indefinitely.