Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Navigate the callstack in debug-prompt eval_code #270

Closed
timholy opened this issue Mar 26, 2019 · 3 comments
Closed

[FR] Navigate the callstack in debug-prompt eval_code #270

timholy opened this issue Mar 26, 2019 · 3 comments

Comments

@timholy
Copy link
Contributor

timholy commented Mar 26, 2019

It would be nice to be able to move up and down the call stack in a manner that allows commands you enter at the debug prompt to reflect that scope. What about replacing the current Callstack with a popup menu?

@pfitzseb
Copy link
Member

What do you think about making the stack level clickable? That would then also change the prompt to e.g. 3|debug>.
I'm not entirely sure how this would interact with stepping though -- changing to a different callstack level should presumably move the stepper widget to the right place, but you couldn't actually step on from there (that should only be possible from the lowest level).

@timholy
Copy link
Contributor Author

timholy commented Mar 27, 2019

Right. Before you step you call leaf(frame), if your internal storage of frame reflects what the user clicked.

@pfitzseb
Copy link
Member

Implemented in JunoLab/atom-ink@ba17078, JunoLab/Atom.jl@ea9c1f1, and JunoLab/atom-julia-client@9ad603d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants