Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Toolbar popups show mac shortcuts keys on Windows #339

Closed
adamsiembida opened this issue Aug 5, 2019 · 1 comment
Closed

[BUG] Toolbar popups show mac shortcuts keys on Windows #339

adamsiembida opened this issue Aug 5, 2019 · 1 comment

Comments

@adamsiembida
Copy link

adamsiembida commented Aug 5, 2019

I installed Juno on Windows 10 using the 64-bit binary for the latest (non-beta) release. Even although I am on Windows, I am getting mac shortcuts using Cmd instead of Ctrl when I mouse over the sidebar. Windows doesn't have a Cmd key so I believe this is a bug.

Details

  • Atom version: 1.39.1
  • Julia version: 1.1.1, 64-bit
  • OS: Windows 10, 64-bit
  • Package versions:
    • Atom.jl: 0.8.8
    • julia-client: 0.8.12-beta2
    • ink: 0.10.11

Steps to reproduce

  1. Install Julia, Windows 10, 64-bit binary.
  2. Install Juno.
  3. Mouse over the shortcuts in the toolbar.

Shortcuts like Save and Open correctly show Ctrl+S and Ctrl+O, while most of the julia specific shortcuts show Cmd instead of Ctrl.

For example, Stop Julia shows Cmd+J Cmd+K, Show Console shows Cmd+J Cmd+O, however Interrupt Julia correctly shows Ctrl+C.

@pfitzseb
Copy link
Member

pfitzseb commented Aug 7, 2019

Fixed with JunoLab/atom-julia-client@f545fcd.

@pfitzseb pfitzseb closed this as completed Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants