Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Revise not loaded on latest version #389

Closed
SebRollen opened this issue Oct 8, 2019 · 6 comments
Closed

[BUG] Revise not loaded on latest version #389

SebRollen opened this issue Oct 8, 2019 · 6 comments
Labels

Comments

@SebRollen
Copy link

Please search existing issues to avoid duplicates.

Details

  • Atom version: 1.40.1
  • Julia version: 1.2.0
  • OS: osX
  • Package versions:
    • Atom.jl: 0.11.0
    • julia-client: 0.11.1
    • ink: 0.11.2

Steps to reproduce

  1. Have using Revise in your ~/.julia/config/startup.jl file
  2. run Revise in your Juno REPL

If I open Julia from a terminal, Revise gets loaded from my startup file, but after the latest updates to Atom.jl, the same doesn't work in Juno

@SebRollen SebRollen added the bug label Oct 8, 2019
@SebRollen
Copy link
Author

Strangely, other things defined in my startup.jl such as OhMyREPL and some ENV declarations are loaded

@SebRollen
Copy link
Author

Apologies, managed to solve this issue myself. Using the recommended

atreplinit() do repl
    try
        @eval using Revise
        @async Revise.wait_steal_repl_backend()
    catch
    end
end

does not work for me, but if I switch to just using using Revise, everything works

@SebRollen
Copy link
Author

On further testing, it seems like even though the name Revise is now available in my repl, the revise functionality isn't actually working. Re-opening

@SebRollen SebRollen reopened this Oct 8, 2019
@aviatesk
Copy link
Member

aviatesk commented Oct 9, 2019

You have some error log ? If you wrap it in try block, please remove that and report back to us.

But most probably, the error you're facing is already fixed timholy/Revise.jl#369 and/or JunoLab/Atom.jl@81167e6.
Then the temporal fix is to ] add Revise#master

@SebRollen
Copy link
Author

I modified my startup file to look like

atreplinit() do repl
    try
        @eval using Revise
        @async Revise.wait_steal_repl_backend()
    catch e
        rethrow(e)
    end
end

and the error message I get is

InitError: KeyError: key "evalrepl" not found
during initialization of module Revise

which does indeed look like that second link you sent. Will try to update to the master branch of Revise

@SebRollen
Copy link
Author

@aviatesk, that worked, thank you for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants