[BUG] Juno Formatting with SimpleTraits

[theogf]

Please search existing issues to avoid duplicates.

Details

• Atom version:
• Julia version: 1.3.1
• OS: Linux
• Package versions:
  • Atom.jl: 0.12.9
  • julia-client:
  • ink:

Steps to reproduce

1. Use SimpleTraits.jl and create a @traitfn function foo(bar::T) where {T; IsTrait{T}} end
   The Juno automatic formatting (Ctrl+J, Ctrl+F) give the error "no method matching rem_where(::Nothing)"

[pfitzseb]

Works fine for me. What version of JuliaFormatter.jl do you have installed (you can check with pkg> st -m JuliaFormatter)?

Edit: Oh, actually, it doesn't error but still messes up:
@traitfn function foo(bar::T) where {T; IsTrait{T}} end -> @traitfn function foo(bar::T) where {TIsTrait{T}} end

[theogf]

JuliaFormatter is at version 0.3.8

[pfitzseb]

Are you sure it's that line that causes the error (you can check by only selecting that before formatting)?

[theogf]

Here is what it gives when I select a line with @traitfn :

Parsing error for input:
@traitfn function predict_ar(m::TGP, p::Int = 3, n::Int = 1; y_past = get_y(m)) where {T,TGP<:AbstractGP{T};IsMultiOutput{TGP}}
error(::String) at error.jl:33
#format_text#86(::Int64, ::Int64, ::Bool, ::Bool, ::Bool, ::Bool, ::JuliaFormatter.DefaultStyle, ::typeof(JuliaFormatter.format_text), ::String) at JuliaFormatter.jl:291
(::JuliaFormatter.var"#kw##format_text")(::NamedTuple{(:indent, :margin, :always_for_in, :whitespace_typedefs, :whitespace_ops_in_indices, :remove_extra_newlines),Tuple{Int64,Int64,Bool,Bool,Bool,Bool}}, ::typeof(JuliaFormatter.format_text), ::String) at none:0
(::Atom.var"#308#309")(::Dict{String,Any}) at formatter.jl:14
handlemsg(::Dict{String,Any}, ::Dict{String,Any}) at comm.jl:168
(::Atom.var"#19#21"{Array{Any,1}})() at task.jl:333

[theogf]

The rem_where issue was when I was selecting the whole function

[pfitzseb]

Ah ok, I can repro with that function.
Wanna open an issue about this at the JuliaFormatter repo?

[theogf]

Sure!
Probably it's the combination of comas and semicolumn...

[aviatesk]

closed since the upstream issue has been solved.