Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Highlighting For Multiple Line Type Signatures #1

Closed
mizunashi-mana opened this issue Apr 6, 2016 · 5 comments
Closed

Incorrect Highlighting For Multiple Line Type Signatures #1

mizunashi-mana opened this issue Apr 6, 2016 · 5 comments
Labels

Comments

@mizunashi-mana
Copy link

Thanks for awesome plugin!

I wrote haskell codes such as:

dbPageWrapper :: (DashBoardPage p, Monad m) =>
  T.Text -> p -> HtmlT m a -> HtmlT m b -> HtmlT m b -- disable type highlighting
dbPageWrapper pref page headerC mainC = do
  ...

Then, I noticed missing syntax.

I use GHC 7.10.3. Probably, because building is passed, this is legal syntax.

@JustusAdam
Copy link
Owner

Yes, I know what you mean. I believe this is a shortcoming of the Haskell texmate bundle. I will open an issue there, perhaps we can fix this.

@JustusAdam JustusAdam changed the title Missing multiple line comment Incorrect Highlighting For Multiple Line Type Signatures Apr 7, 2016
@mizunashi-mana
Copy link
Author

@JustusAdam I see. Thanks for your excellent understanding!

@JustusAdam
Copy link
Owner

I took a closer look at the regexes myself and it almost seems to me to be not an issue of the regex itself, but it seems that the matching algorithm is designed to match line-by-line and the regex is written such that it matches the entire signature at once.

I'll investigate this further and perhaps change the matchings to match partial signatures, which naturally should then allow multi line type signatures to be matched correctly, hopefully.

@JustusAdam
Copy link
Owner

Resolved as of 271fd41

@mizunashi-mana
Copy link
Author

@JustusAdam Thanks for your great works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants