Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested parentheses in imports/exports are not parsed correctly #69

Closed
sheaf opened this issue Nov 5, 2018 · 3 comments
Closed

Nested parentheses in imports/exports are not parsed correctly #69

sheaf opened this issue Nov 5, 2018 · 3 comments
Labels

Comments

@sheaf
Copy link
Collaborator

sheaf commented Nov 5, 2018

See for instance:
parentheses_in_imports_and_exports

@JustusAdam
Copy link
Owner

So it seems to me there are at least two problems here.

  1. at least in export lists numbers are not considered part of a functions name
  2. Export lists are prematurely terminated in the presence of a closing paren. This does not change with the addition or removal of a newline.

@sheaf
Copy link
Collaborator Author

sheaf commented Nov 6, 2018

The weird colouring for the numbers is due to the parenthesis bug, it works fine otherwise:
import_parentheses

Without nesting parentheses, it works fine:
import_parentheses_2

@aryairani
Copy link

Same here:

Good code, bad parse:
image

vs bad code, good parse? (improperly deleted last char of 3rd line)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants