Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loose chapters marked as read #1157

Closed
ThePromidius opened this issue Mar 17, 2022 · 0 comments · Fixed by #1158
Closed

Loose chapters marked as read #1157

ThePromidius opened this issue Mar 17, 2022 · 0 comments · Fixed by #1158
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@ThePromidius
Copy link
Contributor

TLDR:
-> Tachiyomi sends chapter 0.0 when there's no chapters read.
-> Kavita marks all loose chapters as read

Describe the bug
When there is nothing read (when you just tracked the manga for the first time) tachiyomi sends a request and sends 0.0
our encoding starts at 0.001 not at 0.0
Also 0.0 are the specials which we don't track

The problem is that when 0.0 is passed, kavita marks as read all the chapters that are in volume 0 (loose chapters)

To Reproduce

 I/okhttp.OkHttpClient: --> POST http://192.168.0.135:5000/api/Reader/mark-chapter-until-as-read?seriesId=1&chapterNumber=0.0

This is marking volume 0 as read, hence marking loose chapters as read.
This request is sent when tracking a serie in tachiyomi. So unless there's read chapters already, current progress is 0.0

Expected behavior
To not mark loose chapters as read

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
Add any other context about the problem here.

@ThePromidius ThePromidius added the needs-triage Needs to be triaged by a developer and assigned a release label Mar 17, 2022
@ThePromidius ThePromidius changed the title Tachiyomi: Loose chapters marked as read Loose chapters marked as read Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant