Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view_thread only fires the first time an email in a thread is clicked on #797

Open
ek23 opened this issue Sep 27, 2024 · 2 comments
Open

Comments

@ek23
Copy link
Contributor

ek23 commented Sep 27, 2024

Steps to reproduce:

  1. Open a thread with more than one email: view_thread will fire for the latest/bottom email in the thread
  2. Click the previous email in the thread: view_thread will fire for the the selected email in the thread
  3. Click back to the latest/bottom: view_thread will not fire

I believe this can be fixed with the following change. Will fork and put in a PR

image

@ek23 ek23 changed the title view_thread only fires the first time a thread is clicked on view_thread only fires the first time an email in a thread is clicked on Sep 27, 2024
@ek23
Copy link
Contributor Author

ek23 commented Sep 27, 2024

From the documentation, it looks like I have described how view_email should work rather than view_thread. view_thread has always worked fine as a replacement for view_email until recently, but I'm not sure if this fix is appropriate for view_thread. @josteink what do you think?

@josteink
Copy link
Collaborator

If you can fix this with a simple PR, I'm very much open to that.

If you can provide the PR, I will try to test it and get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants