Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Web Services compatibility #102

Closed
hugo opened this issue Oct 14, 2019 · 3 comments
Closed

Amazon Web Services compatibility #102

hugo opened this issue Oct 14, 2019 · 3 comments

Comments

@hugo
Copy link

hugo commented Oct 14, 2019

I'm working on a service that will sit in AWS, behind an ALB. Amazon has a feature where you can to auth at the ALB, and your application will be provided with JWTs in specific headers. Unfortunately, the x-amzn-oidc-data header comes with incorrect base64 encoding, which means that spec-conformant libraries will not verify it's tokens.

Would you be willing to accept a patch that added an AWS-compat mode? I'm happy to write it, but I don't want to just open a PR if it's not a use case you're interested in supporting.

@Keats
Copy link
Owner

Keats commented Oct 14, 2019

Is that still the case recently? I found auth0/node-jws#84 (comment)
IMO it doesn't really makes sense to add support for a bug, in that link above they said they were changing it but it does suck :/

@hugo
Copy link
Author

hugo commented Oct 14, 2019

It's still an issue. They've at least acknowledged that it's a bug, but it's not looking like it will be fixed any time soon. Perhaps I'll just write a blog post and put up a demo repo showing how to work around the problem, while it persists.

@Keats
Copy link
Owner

Keats commented Nov 27, 2019

I can add a link to that in the README when you publish it!

@Keats Keats closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants