Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lareevaar assist + Vishraams #1109

Open
tarunsingh5 opened this issue Jun 10, 2020 · 10 comments
Open

Lareevaar assist + Vishraams #1109

tarunsingh5 opened this issue Jun 10, 2020 · 10 comments

Comments

@tarunsingh5
Copy link
Collaborator

turning on vishraams turns off lareevar assist - we should support both being on

@saintsoldierx
Copy link
Collaborator

image

@plug-n-play
Copy link
Collaborator

Still can't turn both larivaar assist and vishraam options together. When trying to turn on one, other gets turned off.

@saintsoldierx
Copy link
Collaborator

@gurjit03

@saintsoldierx
Copy link
Collaborator

I don't think we actually have done this yet? I may have mistakenly marked it as fixed. Gurjit, please confirm

@gurjit03
Copy link
Collaborator

@saintsoldierx @plug-n-play haven't worked on this yet.

@gurjit03
Copy link
Collaborator

@saintsoldierx needs some inputs on UI here.

@saintsoldierx saintsoldierx self-assigned this Jan 5, 2021
@saintsoldierx saintsoldierx modified the milestones: 2021.1, 2021.2 Jan 19, 2021
@navdeepsingh navdeepsingh self-assigned this Mar 29, 2021
@saintsoldierx saintsoldierx modified the milestones: 2021.2, 2021.3 Apr 6, 2021
@saintsoldierx saintsoldierx modified the milestones: 2021.3, 2021.4 May 12, 2021
@saintsoldierx saintsoldierx removed this from the 2021.4 milestone Aug 18, 2021
@saintsoldierx saintsoldierx added this to the Backlog milestone Aug 18, 2021
@saintsoldierx
Copy link
Collaborator

I gave UI input above @gurjit03 - rather than a circle, let's make it a solid square, orange or red.

@gurjit03
Copy link
Collaborator

gurjit03 commented Jun 25, 2024

@saintsoldierx cool thanks, I will get this !

@Gauravjeetsingh
Copy link
Collaborator

I had a slightly different idea for this, shared on slack, posting here for reference:

How about using the text color for vishraams, and use the background color for assist. Something like this:
image

Another idea, I had was using text overline for larivaar assist, but I personally liked background color more.
image

@Gauravjeetsingh
Copy link
Collaborator

Gauravjeetsingh commented Jul 9, 2024

Also, whatever we finalize here, we can do the same in sttm-desktop to maintain the consistency. Currently desktop version also disables vishraams, if larivaar assist is turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants