[feat]: New Shortcuts

[AkalUstat]

https://drive.google.com/open?id=1ILu1IqxxnFCV8Rs4BAHHC0qTl3CvTdx_6p-EeA--lKY

• Passed sanity tests.
• Ran npm test & fixed newly introduced lint errors.
• Checked console for errors.

[Gauravjeetsingh]

@AkalUstat ji, I am unable to use the keyboard shortcuts.

Testing it here
https://khalis-herok-shortcuts-jwps3u1.herokuapp.com/shabad?id=903

Do I need to enable it from somewhere or something?

[AkalUstat]

You have to be clicked on the shabad viewer. Found that hukamnama, search, and ang have that component in common so that is where i put. I could put it higher up in the component tree if you like

[Gauravjeetsingh]

Can you check once, it's not working for me in hukamnama page as well. Also, I see the blue outline everywhere.

[Gauravjeetsingh]

Keys not working as of now (which you have mostly fixed I think), and there's a blue outline on the viewer.

[AkalUstat]

@saintsoldierx I will create some user info for this stuff in a separate PR

[Gauravjeetsingh]

Looks good to me. Awesome work @AkalUstat

I only have a concern about the keyboard shortcuts we use
For Shahmukhi transliteration toggle, we use: ctrl + alt + shift + t + s, that's five keys. It takes both hands to toggle that. It can be done with one hand as well, but all fingers are used and are put in a weird position.

Also, @AkalUstat are we using the same shortcut keys that are currently in desktop, if not, we should.

@saintsoldierx @maneetpaul @ManjotS veerjis, can any of you you review the shortcut keys used here if you haven't yet.

[AkalUstat]

Looks good to me. Awesome work @AkalUstat

I only have a concern about the keyboard shortcuts we use
For Shahmukhi translation toggle, we use: ctrl + alt + shift + t + s, that's five keys. It takes both hands to toggle that. It can be done with one hand as well, but all fingers are used and are put in a weird position.

Also, @AkalUstat are we using the same shortcut keys that are currently in desktop, if not, we should.

@saintsoldierx @maneetpaul @ManjotS veerjis, can any of you you review the shortcut keys used here if you haven't yet.

1. Yea I agree with the translit toggle; problem is if we do cmd+alt+e (for english translit, without the shift and the t) due to an issue with alt +_ e it messes up all the other shortcuts. I can try to debug and see if i can come up with resolution

2. Only desktop one that matches is Cmd + /. Desktop does not have shortcuts to modify display items. Waiting on react refactor to add these to desktop

[Gauravjeetsingh]

Found a small bug
For toggling Shahmukhi transliteration, one has to take the hand up from all five keys and press again.
For example with Hindi transliteration, I just pick my finger from last key and press again and it works.

[AkalUstat]

Interesting...I will try to debug as well

[AkalUstat]

There is error when the alt key is used for shortcuts in the library, documented here greena13/react-hotkeys#269 so we need new mappings for translit characters to avoid the long shortcuts

[plug-n-play]

Great. We should also document the keyboard shortcuts both in the ReadMe.md and somewhere in the application - may be in the footer? @saintsoldierx thoughts?

[AkalUstat]

I was thinking maybe the help menu (but for another pr) and then a quick help toggle at the top bar

[AkalUstat]

New transliteration keymaps:
shift+e: english
shift+s: shahmukhi
shift+h hindi

[Gauravjeetsingh]

Looks good to me. ✔️
Just a suggestion for one more shortcut; can we do shift + v for Larivaar assist?

[AkalUstat]

added shift + l shortcut for larivar assist