Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive testing, CI, and CD for vulkan.cppm #1993

Open
sharadhr opened this issue Nov 13, 2024 · 0 comments
Open

Comprehensive testing, CI, and CD for vulkan.cppm #1993

sharadhr opened this issue Nov 13, 2024 · 0 comments

Comments

@sharadhr
Copy link
Contributor

The vulkan.cppm module needs more rigorous automated testing, CI and CD; there is currently only one test that doesn't exercise both the entirety of the module and potential compiler bugs that could be exposed with more testing (such as #1943 which is an MSVC-specific problem).

Of course, given the still-experimental status of C++ standard modules as a whole, any CI/CD failures shouldn't block merges, but regressions should.

Just for testing vulkan.cppm, I propose setting up Actions each with the latest possible compilers for maximum coverage:

  • Windows 11
    • Latest MSVC
    • Latest LLVM/Clang for MSVC ABI
  • macOS Sequoia
    • Latest Xcode AppleClang
    • Latest LLVM/Clang
  • Linux
    • Latest GCC
    • Latest LLVM/Clang

I propose restricting to only the latest possible compilers as C++ standard modules are so new. As new compilers are released these environments should be periodically updated to follow new compiler version updates.

Next, I propose porting the existing tests in samples and tests as well as the entirety of Sascha Willems' Vulkan samples to use vulkan.cppm.

This will provide very comprehensive code and toolchain coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant