Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkcube should treat VK_KHR_display as runtime command-line switch, not as cmake option #307

Closed
jjulianoatnv opened this issue Dec 13, 2019 · 0 comments · Fixed by #1029
Closed
Labels
enhancement New feature or request vkcube

Comments

@jjulianoatnv
Copy link
Contributor

The way that vkcube is structured today, the choice to use VK_KHR_display to drive a direct-to-display is a cmake option when configuring the build.

if(UNIX AND NOT APPLE) # i.e. Linux
...
    set(CUBE_WSI_SELECTION "XCB" CACHE STRING "Select WSI target for vkcube (XCB, XLIB, WAYLAND, DISPLAY)")

This means a separate vkcube binary is required in order to test VK_KHR_display.

It would be better if the choice between windowing system swapchain and VK_KHR_display swapchain was controlled by a runtime switch specified on the command line. This issue requests that the choice of DISPLAY be moved to a command line switch.

Extrapolating, the choice between XCB and XLIB and WAYLAND could also become command-line options; however I am not requesting such a change in this issue. If there is desire to go this extra distance then it can be done in the context of a different gitlab issue.

Further, by placing the DISPLAY support inside of a check for UNIX, this precludes ever exposing VK_KHR_display on Windows or on any other non-UNIX platform. That is short-sighted. A better software architecture would structure the code such that support for DISPLAY is independent of the windowing system choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vkcube
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants