Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronization validation failure related to dynamic descriptor set #3605

Open
cclao opened this issue Dec 14, 2021 · 5 comments
Open

synchronization validation failure related to dynamic descriptor set #3605

cclao opened this issue Dec 14, 2021 · 5 comments
Assignees
Labels
Bug Something isn't working

Comments

@cclao
Copy link

cclao commented Dec 14, 2021

Describe the Issue
synchronization validation failure related to dynamic descriptor set

Valid Usage ID
This is found with ANGLE. ANGLE is OpenGLES implementation on top of vulkan. We recently implemented buffer sub-allocation from VkBuffer and run into syncval failure. The failure goes away if I disable the use of VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC. My guess is that when dynamic uniform buffer is used, the actual buffer range been used for uniform buffer maybe not been calculated properly, which result in false hazard detection.

Environment:

  • OS:
  • GPU:
  • SDK or header version if building from repo:
  • Options enabled (synchronization, best practices, etc.):

Additional context

@spencer-lunarg
Copy link
Contributor

sorry for the late reply. @cclao is there any more information about this issue, an api dump or something to help reproduce?

@ianelliottus
Copy link
Contributor

@spencer-lunarg both @mark-lunarg and @mikes-lunarg know how to build ANGLE. I will ask @cclao to coordinate with them.

@cclao
Copy link
Author

cclao commented Oct 14, 2022

Hi Spencer, to reproduce, you need to build ANGLE.

  1. Remove these lines of code that skip the specific VVL error described here.
    https://chromium.googlesource.com/angle/angle/+/refs/heads/main/src/libANGLE/renderer/vulkan/RendererVk.cpp#406
    to line 424
  2. Build and install ANGLE, and run all tests we have. Or the alternative way is try to run in ANGLE CI bots and some tests will fail and you can start from that.
    There are more information in this bug as well
    https://bugs.chromium.org/p/angleproject/issues/detail?id=6725

@spencer-lunarg spencer-lunarg self-assigned this Oct 15, 2022
@spencer-lunarg spencer-lunarg added the Bug Something isn't working label Oct 15, 2022
@spencer-lunarg
Copy link
Contributor

@cclao I commented out the 4 errors from the file (under http://anglebug.com/6725) and built ANGLE (release, hope that wouldn't matter) and ran

angle/out/Release/bin$ ./run_angle_deqp_gles31_tests --use-angle=swiftshader --gtest_filter=functional.draw_indirect.compute_interop.separate.* --verbose --local-output --verbose-logging

and it passed the tests, am I missing something obvious here?

@mark-lunarg
Copy link
Contributor

@spencer-lunarg, DM'd you some hints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants