Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exception globs #8566

Open
zmike opened this issue Sep 20, 2024 · 1 comment
Open

exception globs #8566

zmike opened this issue Sep 20, 2024 · 1 comment
Assignees
Labels
Enhancement New feature or request

Comments

@zmike
Copy link
Contributor

zmike commented Sep 20, 2024

All the draw/dispatch VUIDs are duplicated for every draw/dispatch command (e.g., a VU for vkCmdDraw also exists for vkCmdDrawIndexed). It's annoying to have to add exceptions (khronos_validation.message_id_filter) for every variant. Would be very nice if there was some way to just glob by the VUID number instead of the full string.

@spencer-lunarg spencer-lunarg self-assigned this Sep 20, 2024
@spencer-lunarg
Copy link
Contributor

The current issue is we take the full string and hash it (to do the filtering and message limits)

A simple solution could be to make 2 hash, so one for VUID-vkCmdDrawIndexed-magFilter and one for 04553 and detect either... we would also need to update message_id_filter to handle just 04553

my only other worry is if people have checks in their own custom callbacks, I am trying to figure out a way (besides creating a message_id_filter_2) to not just break people

@spencer-lunarg spencer-lunarg added the Enhancement New feature or request label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants