Skip to content
This repository has been archived by the owner on May 12, 2019. It is now read-only.

Incorrect margin-top in 404 page with different viewports #68

Closed
mickeyhoh opened this issue Sep 9, 2015 · 6 comments
Closed

Incorrect margin-top in 404 page with different viewports #68

mickeyhoh opened this issue Sep 9, 2015 · 6 comments
Labels
Milestone

Comments

@mickeyhoh
Copy link

Hi Kiko
Thanks for aligning the background images for both mobile devices vs desktop/notebook to make them consistent for release 2.5.0. Similarly thanks for fixing the Error bug.

As mentioned earlier, scrolling is required for the Error page, to access the Panic and Safe buttons. I would suggest to reduce the page size, to minimize scrolling, for UX purposes.

Once again, keep up the good work!

@mickeyhoh
Copy link
Author

My current notebook resolution is 1366 X 768.
My mobile device is Android with 5 inch screen.
Hope this helps?

@Kikobeats
Copy link
Owner

something that I don't understand is why you say cover.jpg. This file is not more longer necessary, now automatically is resolved from the setting in the admin panel.

btw, what browser do you use? I tested responsive version using chrome dev tools and looks well :-(

@Kikobeats Kikobeats added the bug label Sep 10, 2015
@Kikobeats Kikobeats modified the milestone: 2.5.2 Sep 10, 2015
@mickeyhoh
Copy link
Author

image
The above is the screenshot via my browser. What you see is the whole screen (with the browser parts cropped off), as well as the vertical scrolling bar on the right.
This clearly shows that the web page is too big for my browser even on my resolution mentioned earlier.
Shouldn't the page auto-adjust its size somehow?
For notebook, I am using Chrome v45 on Windows 7.

@mickeyhoh
Copy link
Author

Lets forget about the cover.jpg. I understand that you have improved the codes. Sorry for the misunderstanding.
If I view the error page on my Android phone using Chrome 45 as well, the same scrolling is required and the last words I could see are 'What happens now?' before I need to scroll down to see the 2 buttons.

@Kikobeats Kikobeats added this to the 2.5.2 milestone Sep 11, 2015
@Kikobeats
Copy link
Owner

the problem is related with the viewport height, I want to fix quickly :-)

@Kikobeats Kikobeats changed the title Background cover.jpg Incorrect margin-top in 404 page with different viewports Sep 11, 2015
@mickeyhoh
Copy link
Author

Thanks Kikobeats! All looks good now. I used your latest release :)
You have been very fast and good. Well done!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants