Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Aether / Curios #35

Open
Cartrigger opened this issue Oct 10, 2024 · 9 comments
Open

The Aether / Curios #35

Cartrigger opened this issue Oct 10, 2024 · 9 comments
Labels
C-load Crash: Forge mod not loading past MC loading screen C-mixin Crash: Mixin incompatibility P-high Priority: High T-crash Type: Crash

Comments

@Cartrigger
Copy link

Cartrigger commented Oct 10, 2024

Version information

The Aether - 1.20.1 - 1.5.0-neoforge

Reproduction Steps

Put the mod in the mods folder
Start the game
profit

Java version

21

Crash Report file

https://mclo.gs/y1boItq

Additional information

Seems to be a issue with curios and other JIJ mods

@Cartrigger Cartrigger added S-needs triage Status: Needs Triage T-crash Type: Crash labels Oct 10, 2024
@Cartrigger Cartrigger changed the title The Aether The Aether / Curios Oct 10, 2024
@BluSpring BluSpring added C-load Crash: Forge mod not loading past MC loading screen P-high Priority: High and removed S-needs triage Status: Needs Triage labels Oct 11, 2024
@BluSpring
Copy link
Collaborator

It is not, but fixing this crash might involve some ASM trickery, which I was already intending on doing anyway to make this class work.

@Cartrigger
Copy link
Author

I meant the crash is from probably other JIJ mods included, not JIJ itself

@BluSpring BluSpring added the C-mixin Crash: Mixin incompatibility label Oct 18, 2024
@BluSpring
Copy link
Collaborator

BluSpring commented Oct 21, 2024

There exists a new crash with the Aether that I legitimately cannot fix due to FabricMC/Mixin#134 having not been fixed.
This is gonna be a fun experience.

@Cartrigger
Copy link
Author

time to do the waiting game until merged?

@HackMeMan
Copy link

Would FabricMC/Mixin/pull/154 fix this? It's still pending, and only time will tell when it'll get merged, but I see it as a simple fix

@kir-kir
Copy link

kir-kir commented Oct 24, 2024

Yes.

@HackMeMan
Copy link

Then I guess we're just going to have to play the waiting game

@BluSpring
Copy link
Collaborator

Fixed in d6eef67.

@Cartrigger
Copy link
Author

https://mclo.gs/zg4A2Ps its not fixed

@BluSpring BluSpring reopened this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-load Crash: Forge mod not loading past MC loading screen C-mixin Crash: Mixin incompatibility P-high Priority: High T-crash Type: Crash
Projects
None yet
Development

No branches or pull requests

4 participants