Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-feedback functions doesn't fire on step-title navigation #66

Open
ghost opened this issue Feb 2, 2019 · 3 comments
Open

Data-feedback functions doesn't fire on step-title navigation #66

ghost opened this issue Feb 2, 2019 · 3 comments

Comments

@ghost
Copy link

ghost commented Feb 2, 2019

When linear is set, data-feedback of next-step button should be called when clicking on next step-title.

@ghost ghost mentioned this issue Feb 2, 2019
@Kinark
Copy link
Owner

Kinark commented Feb 2, 2019

This is also theoretical problem.

When I've made the data-feedback into the buttons I wanted to have a way to offer an option for the users to skip the feedback, if necessary.

I believe that the best solution is to add feedback functions to the steps themselves as well (despite the buttons).

@ghost
Copy link
Author

ghost commented Feb 3, 2019

That's a good idea. I think all feedback and validation functions should be done on step switch

@Kinark
Copy link
Owner

Kinark commented Feb 4, 2019

The problem with this is that what if you want to do an optional feedback-function?
The others validation functions are all executed on step switch.

@Kinark Kinark changed the title Linear stepper not proper. Data-feedback functions doesn't fire on step-title navigation Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant