Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Refactor unit test assertions #78

Open
5 of 13 tasks
kselena opened this issue Sep 9, 2022 · 0 comments
Open
5 of 13 tasks

🚧Refactor unit test assertions #78

kselena opened this issue Sep 9, 2022 · 0 comments
Labels
good-first-issue Good for newcomers medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction

Comments

@kselena
Copy link
Member

kselena commented Sep 9, 2022

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Refactor all of the unit test assertions to use the FluentAssertions library.

This will greatly cleanup the unit testing side of things and make the creation of unit tests easier.

Acceptance Criteria

  • Latest version of FluentAssertions Nuget package added to the project
  • Refactor the files below:
    • OwnerDoesNotExistExceptionTests.cs - 49 lines
    • RepoDoesNotExistExceptionTests.cs - 49 lines
    • ValuesMismatchExceptionTests.cs - 49 lines
    • VersionKeysNotFoundExceptionTests.cs - 49 lines
    • EnsureThatTests.cs - 42 lines

ToDo Items

  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Issue linked to the correct project (if required).
  • Issue linked to the correct milestone (if required).

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking changes
New Feature ✨new feature
Workflow Changes workflow
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.Refa
@kselena kselena added medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction labels Sep 9, 2022
@kselena kselena added this to KD-Team Sep 9, 2022
@kselena kselena moved this to ⚪Not Set in KD-Team Mar 10, 2023
@CalvinWilkinson CalvinWilkinson added the good-first-issue Good for newcomers label May 8, 2023
@CalvinWilkinson CalvinWilkinson added the 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! label Oct 2, 2023
@CalvinWilkinson CalvinWilkinson removed the 🍺hacktoberfest-easy Easy issue for new developers for hacktoberfest!! Hack away!! label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers medium-priority Medium Priority tech-debt Code refactoring or cleanup / tech debt reduction
Projects
Status: ⚪Not Set
Development

No branches or pull requests

2 participants