Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file pane is a weird ux #3248

Closed
jessfraz opened this issue Aug 3, 2024 · 3 comments
Closed

file pane is a weird ux #3248

jessfraz opened this issue Aug 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@jessfraz
Copy link
Contributor

jessfraz commented Aug 3, 2024

video attached

but dont create the file/folder by default, instead wait until they input something

otherwise you just have more clicks to delete this file you didnt want

Screenshare.-.2024-08-02.8_52_25.PM.mp4
@franknoirot
Copy link
Collaborator

Currently, clicking these buttons in the file pane UI immediately creates a new file or folder with the name "Untitled" and an index suffix, then sets that new item to be in "renaming mode" so you can immediately set its name.

Screenshot 2024-08-21 at 8 59 15 PM

Instead, we should follow the example of VS Code. Clicking those buttons opens a UI form to set its name, and if you submit this form the file or folder is then created. If you cancel with Esc or by blurring focus on the input no file system access occurs.

This should include an Electron E2E test or Vitest component test of the behavior.

@Irev-Dev
Copy link
Collaborator

Irev-Dev commented Sep 5, 2024

Jordan made the following comments

right click on KCL file window only accepts a click ontop of the shortcut, additionally right click window doesn’t dissapear upon part deletion

Screen.Recording.2024-09-04.at.8.00.10.PM.mp4

renaming should auto close the right click window.. doesnt feel right

Screen.Recording.2024-09-04.at.8.02.21.PM.mov

@jessfraz's suggestion is instead of fixing individually is to just follow vcode patterns for the file pane.

@lf94 lf94 assigned lf94 and unassigned franknoirot Sep 27, 2024
@lf94
Copy link
Contributor

lf94 commented Sep 30, 2024

Ok these two were fixed by someone at one point (probably during the tauri transition):

  1. right click on KCL file window only accepts a click ontop of the shortcut, additionally right click window doesn’t dissapear upon part deletion
  2. renaming should auto close the right click window.. doesnt feel right

I'll fix up the create file / directory to match vs code

@lf94 lf94 closed this as completed Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants