-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file pane is a weird ux #3248
Comments
Currently, clicking these buttons in the file pane UI immediately creates a new file or folder with the name "Untitled" and an index suffix, then sets that new item to be in "renaming mode" so you can immediately set its name. Instead, we should follow the example of VS Code. Clicking those buttons opens a UI form to set its name, and if you submit this form the file or folder is then created. If you cancel with Esc or by blurring focus on the input no file system access occurs. This should include an Electron E2E test or Vitest component test of the behavior. |
Jordan made the following comments
Screen.Recording.2024-09-04.at.8.00.10.PM.mp4
Screen.Recording.2024-09-04.at.8.02.21.PM.mov@jessfraz's suggestion is instead of fixing individually is to just follow vcode patterns for the file pane. |
Ok these two were fixed by someone at one point (probably during the tauri transition):
I'll fix up the create file / directory to match vs code |
video attached
but dont create the file/folder by default, instead wait until they input something
otherwise you just have more clicks to delete this file you didnt want
Screenshare.-.2024-08-02.8_52_25.PM.mp4
The text was updated successfully, but these errors were encountered: