Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users cache size limit #86

Open
djones6 opened this issue Aug 30, 2019 · 0 comments
Open

Users cache size limit #86

djones6 opened this issue Aug 30, 2019 · 0 comments

Comments

@djones6
Copy link
Contributor

djones6 commented Aug 30, 2019

The usersCache currently does not have a size limit. I've read that NSCache purges entries when a device is running low on memory, but I'm not sure I understand how that translates to a server context (there may be memory available, but we don't necessarily want to use it). I'm also not sure whether that functionality exists in the open-source Foundation used on Linux.

Perhaps Credentials.register should accept an optional cacheLimit argument that sets the NSCache.countLimit for the plugin being registered. As Credentials itself creates the cache, there's no change required for the plugins themselves.

This applies to the 'original' Credentials plugins; the type-safe credentials implementations already provide their own way to set the countLimit for the token cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant