Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WHERE IN clauses #114

Open
djones6 opened this issue Jul 1, 2019 · 1 comment
Open

Use WHERE IN clauses #114

djones6 opened this issue Jul 1, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@djones6
Copy link
Contributor

djones6 commented Jul 1, 2019

While assembling the WHERE clause for a Filter, judging by the tests, we are producing a list of (item = 'a') OR (item = 'b') rather than using the WHERE item IN (a,b) syntax.

Doing so would mean the query more closely resembles the filter and I think would mean the tests are more readable.

There might be a small benefit also in terms of saving bandwidth (presumably, that verbose query has to go over the wire to the DB). I understand that DB typically translates this into a list of OR clauses anyway, so it doesn't offer any performance advantage in that respect.

@kilnerm
Copy link
Contributor

kilnerm commented Jul 3, 2019

This is definitely worth looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants