From e3c94d59133de24451938b89af7e9d3ea28c59d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Km=C3=ADnek?= Date: Sat, 7 Sep 2024 13:46:16 +0200 Subject: [PATCH] feat: Add some new phpstan rules and prohibit errors in chaotic Nette structure --- app/module/sign/form/SignUpFormFactory.php | 4 ++-- composer.json | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/module/sign/form/SignUpFormFactory.php b/app/module/sign/form/SignUpFormFactory.php index ddd7ec94..ff55dc2d 100644 --- a/app/module/sign/form/SignUpFormFactory.php +++ b/app/module/sign/form/SignUpFormFactory.php @@ -98,9 +98,9 @@ public function create(callable $onSuccess, ?Invitation $invitation = null): \Ne return; } catch (UniqueConstraintViolationException $exc) { if (preg_match("/SQLSTATE\[23000\]: Integrity constraint violation: 1062 Duplicate entry \'(.*?)\' for key \'(.*?)\'/m", $exc->getMessage(), $matches)) { - $form[$exc->getMessage()]->addError("Cannot create user. Field '" . StringHelper::toCamelCase($matches[2]) . " is already used'"); + $form[$exc->getMessage()]->addError("Cannot create user. Field '" . StringHelper::toCamelCase($matches[2]) . " is already used'"); /* @phpstan-ignore-line */ } else { - $form[$exc->getMessage()]->addError("Cannot create user. Already exists'"); + $form[$exc->getMessage()]->addError("Cannot create user. Already exists'"); /* @phpstan-ignore-line */ } return; } diff --git a/composer.json b/composer.json index 3e579135..ace68766 100644 --- a/composer.json +++ b/composer.json @@ -44,8 +44,10 @@ "nette/tester": "^2.0", "squizlabs/php_codesniffer": "^3", "phpstan/phpstan": "^1", - "rector/rector": "^0", + "phpstan/phpstan-deprecation-rules": "^1.1", "phpstan/phpstan-nette": "^1", + "phpstan/phpstan-strict-rules": "^1.5", + "rector/rector": "^0", "roave/security-advisories": "dev-latest", "slevomat/coding-standard": "^8" },