Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement styled-components. #35

Open
AriTheElk opened this issue Nov 11, 2016 · 1 comment
Open

Implement styled-components. #35

AriTheElk opened this issue Nov 11, 2016 · 1 comment

Comments

@AriTheElk
Copy link
Contributor

Currently this is not feasible until styled-components/styled-components#152 is merged, but after that's complete and we've upgraded all dependencies (#26) we should be able to implement styled-components no problem.

Advantages of implementing styled-components:

  • Styles will be editable inline with the TypeScript code. Reducing the total file clutter in the codebase and also enabling developers to quickly locate and modify the CSS related to the current component.
  • Theming will be an absolute breeze. We'll be able to store theme data in json files and then load the required values inside the styled templates.
@AriTheElk
Copy link
Contributor Author

It looks like there's been a lot of progress on the PR to bring TypeScript support to styled-components. Once I clear up some time on my schedule, I'm going to begin working on #26 if @mmarkman hasn't made any progress on it by then; so that we're prepared for styled-components support when it's released 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant