-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No metrics from kong-controller #1053
Comments
As a workaround, I did a simple podMonitor in my values file.
|
Yeah, this looks off. I'm not clear why we actually have a ServiceMonitor here, as both the gateway status and controller metrics ports are designed to not have a Service, as they're exposing per-Pod information. The docs for this look quite out of date and my best guess is that we had a ServiceMonitor originally for the admin API, as earlier versions did not have the dedicated status listen or controller metrics. PodMonitor is probably the correct choice here, and I'm not entirely sure why we didn't switch to it. Kong/kubernetes-ingress-controller#1770 (comment) suggests that we did so to avoid a breaking change, but we can probably handle this with a legacy behavior check that still honors Per that other comment, ServiceMonitor actually should (unintuitively) be fine for ports that lack Services, but I don't recall the specifics of how that works in the upstream operator. My best guess there is that this worked with Tentative AC:
|
Trying to get controller metrics in to prometheus using the ingress chart.
My values file looks like this and I'm using helm chart ingress-0.12.0
Reading https://github.com/Kong/charts/tree/main/charts/kong#prometheus-operator-integration it says that I should
The problem is that there is no
ingressController.labels
charts/charts/kong/values.yaml
Line 531 in 6906fa6
But lets look at the generated servicemonitor
It also seems like there is no service that makes this endpoint public, at least not that works with the label selectors.
So there is no selector that matches all of them even though
kong-controller-validation-webhook
is the closest, but it don't make thecmetrics
port available.To me, it seems like we need to add a new service to the controller that is created when setting
serviceMonitor.enabled: true
and we need to addingressController.labels
.Unless I have missed something obvious. Love to get some feedback on this.
The text was updated successfully, but these errors were encountered: