Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IngressClass template doesn't respect env vars #1100

Open
joran-fonjallaz opened this issue Jul 8, 2024 · 0 comments
Open

IngressClass template doesn't respect env vars #1100

joran-fonjallaz opened this issue Jul 8, 2024 · 0 comments

Comments

@joran-fonjallaz
Copy link

the Kong Ingress Controller offers many flags to configure the executable as defined here https://docs.konghq.com/kubernetes-ingress-controller/latest/reference/cli-arguments/

However, when running Kong Ingress Controller only with Gateway CRDs (GatewayClass, HTTPRoute, etc.), it can be desired to turn off the Ingress capabilities (think for example running and Kong for Ingress resources next to a Kong for Gateway resources during a migration).

However, the IngressClass resource here https://github.com/Kong/charts/blob/main/charts/kong/templates/ingress-class.yaml#L22 doesn't respect the flags below (or the env var)

  • --ingress-class
  • nor --enable-controller-ingress-class-networkingv1

==> none of the flags above disable the creation of the ingressClass, nor changes its name.

I would expect that setting --enable-controller-ingress-class-networkingv1 to false would not create the resource. I would expect that setting --ingress-class to foo would name the IngressClass resource foo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant