Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: versioning #50

Merged
merged 2 commits into from
Sep 7, 2023
Merged

fix: versioning #50

merged 2 commits into from
Sep 7, 2023

Conversation

adamdehaven
Copy link
Member

Summary

Prep CI for future pre-release versions

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@adamdehaven adamdehaven self-assigned this Sep 7, 2023
Comment on lines +204 to +206
"TrendDownIcon.vue",
"TrendUpIcon.vue",
"UnfoldMoreIcon.vue",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were missing in a previous PR

@adamdehaven adamdehaven merged commit 447b9b1 into main Sep 7, 2023
3 checks passed
@adamdehaven adamdehaven deleted the fix/versioning branch September 7, 2023 19:40
kongponents-bot pushed a commit that referenced this pull request Sep 7, 2023
## [1.4.1](v1.4.0...v1.4.1) (2023-09-07)

### Bug Fixes

* versioning ([#50](#50)) ([447b9b1](447b9b1))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants