Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new icons #61

Merged
merged 1 commit into from
Sep 13, 2023
Merged

feat: add new icons #61

merged 1 commit into from
Sep 13, 2023

Conversation

adamdehaven
Copy link
Member

@adamdehaven adamdehaven commented Sep 13, 2023 •
edited
Loading

Summary

Add new icons

Changes from KIcon

image

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@adamdehaven adamdehaven self-assigned this Sep 13, 2023
@adamdehaven adamdehaven marked this pull request as ready for review September 13, 2023 21:37
@adamdehaven adamdehaven requested review from a team and jillztom as code owners September 13, 2023 21:37
@adamdehaven adamdehaven enabled auto-merge (squash) September 13, 2023 21:37
portikM
portikM reviewed Sep 13, 2023
View reviewed changes
svg/solid/forward.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we need this as we already have ArrowRightIcon

@adamdehaven adamdehaven enabled auto-merge (squash) September 13, 2023 21:43
@adamdehaven adamdehaven merged commit 33d3c2c into main Sep 13, 2023
3 checks passed
@adamdehaven adamdehaven deleted the feat/new-icons branch September 13, 2023 21:43
kongponents-bot pushed a commit that referenced this pull request Sep 13, 2023
@semantic-release-bot
chore(release): 1.5.0 [skip ci]
9ca1cd7 
# [1.5.0](v1.4.3...v1.5.0) (2023-09-13)

### Features

* add new icons ([#61](#61)) ([33d3c2c](33d3c2c))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portikM portikM portikM approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

Assignees

@adamdehaven adamdehaven

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamdehaven @kongponents-bot @portikM