Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(*): add new flags and refresh icon #90

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix(*): add new flags and refresh icon #90

merged 1 commit into from
Oct 3, 2023

Conversation

portikM
Copy link
Member

@portikM portikM commented Oct 3, 2023

Summary

Adds flags icons and refresh icon

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@portikM portikM self-assigned this Oct 3, 2023
@portikM portikM requested review from a team, adamdehaven and jillztom as code owners October 3, 2023 16:57
adamdehaven
adamdehaven approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@portikM portikM merged commit fa12f8d into main Oct 3, 2023
4 checks passed
@portikM portikM deleted the fix/flags-and-other-icons branch October 3, 2023 17:05
kongponents-bot pushed a commit that referenced this pull request Oct 3, 2023
@semantic-release-bot
chore(release): 1.7.3 [skip ci]
0b27e88 
## [1.7.3](v1.7.2...v1.7.3) (2023-10-03)

### Bug Fixes

* add new flags and refresh icon ([#90](#90)) ([fa12f8d](fa12f8d))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

Assignees

@portikM portikM

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@portikM @kongponents-bot @adamdehaven