Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin server): an instance for every request #12020

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix(plugin server): an instance for every request #12020

merged 1 commit into from
Nov 16, 2023

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Nov 15, 2023 •
edited
Loading

Summary

As the key changes its definition (cache key) it can never match a plugin's uuid. change to use __plugin_id.

Checklist

Issue reference

Fix KAG-2969

@StarlightIbuki
fix(plugin server): an instance for every request
59bdf75 
As the __key__ changes its definition (cache key) it can never match a plugin's uuid. change to use __plugin_id.

Fix KAG-2969
@gszr gszr merged commit a7e7cb4 into master Nov 16, 2023
34 checks passed
@gszr gszr deleted the fix/instance-leak branch November 16, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gszr gszr gszr approved these changes

@bungle bungle bungle approved these changes

Assignees

@StarlightIbuki StarlightIbuki

Labels
core/language/go core/language/js core/language/python size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StarlightIbuki @bungle @gszr