Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): enable status api by default #12304

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Jan 8, 2024

Summary

Redoing #12254

Checklist

  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md

Issue reference

KAG-3359

Copy link
Contributor

@ADD-SP ADD-SP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about replacing perf with feature? And do the same thing in the changelog.

@chronolaw
Copy link
Contributor

How about replacing perf with feature? And do the same thing in the changelog.

Yes, I think that it is not a "perf".

@ADD-SP
Copy link
Contributor

ADD-SP commented Jan 10, 2024

How about replacing perf with feature? And do the same thing in the changelog.

Yes, I think that it is not a "perf".

@chronolaw feature or refactor?

@chronolaw
Copy link
Contributor

How about replacing perf with feature? And do the same thing in the changelog.

Yes, I think that it is not a "perf".

@chronolaw feature or refactor?

In original PR (#12254), it is "feat(templates)".

@ADD-SP
Copy link
Contributor

ADD-SP commented Jan 10, 2024

How about replacing perf with feature? And do the same thing in the changelog.

Yes, I think that it is not a "perf".

@chronolaw feature or refactor?

In original PR (#12254), it is "feat(templates)".

@StarlightIbuki What do you think?

@chronolaw
Copy link
Contributor

In PR #12268, we reverted #12254, and found some test failings, do you sure those cases are OK now?

@chronolaw chronolaw added this to the 3.6.0 milestone Jan 10, 2024
@StarlightIbuki
Copy link
Contributor Author

StarlightIbuki commented Jan 10, 2024

@ADD-SP @chronolaw Renamed the PR.

In PR #12268, we reverted #12254, and found some test failings, do you sure those cases are OK now?

They are fixed. Please take a look at the change to the kong_test.conf.

@StarlightIbuki StarlightIbuki changed the title perf(core): enable status api by default feat(core): enable status api by default Jan 10, 2024
@StarlightIbuki StarlightIbuki added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 11, 2024
@windmgc windmgc merged commit 15d6f4c into master Jan 11, 2024
30 checks passed
@windmgc windmgc deleted the perf/default-enable-status-api branch January 11, 2024 07:09
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12304-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12304-to-master-to-upstream
git checkout -b cherry-pick-12304-to-master-to-upstream
ancref=$(git merge-base b7a83612f4cf87404e758b42087ff1623a916eb9 ae99c6d693084f817846b1b08fe9cd27c12e66e9)
git cherry-pick -x $ancref..ae99c6d693084f817846b1b08fe9cd27c12e66e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants