fix(kong.conf.default): fix the default value of upstream_keepalive_max_requests
#12643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chobits
changed the title
chobits
force-pushed
the
fix/kong-conf-keepalive-default-value
branch
from
ed15903
to
faa92c7
Compare
chronolaw
approved these changes
Feb 27, 2024
|
Do we need to back port this PR? |
chobits
commented
Feb 27, 2024
| @@ -1020,7 +1020,7 @@ | |||
| # each upstream request to open a new | |||
| # connection. | |||
|
|
|||
| #upstream_keepalive_max_requests = 1000 # Sets the default maximum number of | |||
| #upstream_keepalive_max_requests = 10000 # Sets the default maximum number of | |||
There was a problem hiding this comment.
⭕ See the actual value here:
kong/kong/templates/kong_defaults.lua
Line 73 in e613aa1
Yes, I'll backport it later. But we dont need to cherry pick it to kong-ee, because kong-ee has no this issue. |
Water-Melon
approved these changes
Feb 27, 2024
ADD-SP
approved these changes
Feb 27, 2024
ADD-SP
changed the title
ADD-SP
changed the title
upstream_keepalive_max_requests
ADD-SP
changed the title
upstream_keepalive_max_requestsupstream_keepalive_max_requests
ADD-SP
requested changes
Feb 27, 2024
chobits
force-pushed
the
fix/kong-conf-keepalive-default-value
branch
2 times, most recently
from
51c81c2
to
4aaf426
Compare
This commit fixes the discrepancy between the default value of upstream_keepalive_max_requests in the Kong.conf comments and the actual value in kong/templates/kong_defaults.lua.
chobits
force-pushed
the
fix/kong-conf-keepalive-default-value
branch
from
4aaf426
to
09b23ef
Compare
ADD-SP
approved these changes
Feb 27, 2024
|
Successfully created backport PR for |
3 tasks
|
Successfully created backport PR for |
3 tasks
|
Successfully created backport PR for |
3 tasks
|
Successfully created backport PR for |
bungle
added
the
cherry-pick kong-ee
3 tasks
|
Successfully created backport PR for |
|
Successfully created cherry-pick PR for |
3 tasks
|
Successfully created backport PR for |
3 tasks
|
Successfully created backport PR for |
3 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes the discrepancy between the default value
1000of upstream_keepalive_max_requests in the Kong.conf comments and the actual value10000in kong/templates/kong_defaults.lua.Checklist
The Pull Request has testschangelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREfix KAG-3360