fix(pluginsocket.proto): type for set_upstream
#12727
Conversation
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue #114. Sister PR: Kong/kong#12727
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue Kong/go-pdk#114. Sister PR: Kong/go-pdk#191
gszr
force-pushed
the
fix/pluginsocet-proto
branch
from
13bc72e
to
66712fb
Compare
| @@ -328,7 +328,7 @@ service Kong { | |||
| rpc Router_GetRoute(google.protobuf.Empty) returns (Route); | |||
| rpc Router_GetService(google.protobuf.Empty) returns (Service); | |||
|
|
|||
| rpc Service_SetUpstream(String) returns (google.protobuf.Empty); | |||
There was a problem hiding this comment.
Does it work with only Bool ? The general PDK says that there are 2 values returned: (bool, string) - https://docs.konghq.com/gateway/latest/plugin-development/pdk/kong.service/#kongserviceset_upstreamhost
There was a problem hiding this comment.
Good question!
I have verified the change works for both cases.
Longer answer:
Although it fixes the behavior described in Kong/go-pdk#114, the go-pdk does not currently handle consistently the nil, err protocol adopted in the Lua PDK -- ie, most methods do not return the err on the Go PDK side (only other errors are reported, like connection errors, protobuf errors, etc). Also, on the Go PDK side the SetUpstream method does not return a boolean, only an error. Fixing this means an API breaking change has to be introduced, so this really needs to be done before we release v1.0.0, but not in the scope of this fix. I will add this to my future improvements notes.
There was a problem hiding this comment.
Oh, ok! That makes sense. Thanks 👍 !
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue #114. Sister PR: Kong/kong#12727
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue #114. Sister PR: Kong/kong#12727
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue #114. Sister PR: Kong/kong#12727
gszr
added
the
cherry-pick kong-ee
|
Successfully created cherry-pick PR for |
Summary
Fix the return type for the
.Service.SetUpstreamexternal plugin PDK method.Fixes issue Kong/go-pdk#114.
Sister PR: Kong/go-pdk#191
Issue reference
Fixes issue Kong/go-pdk#114.