Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http-log): add port information to the host header #13116

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(http-log): add port information to the host header #13116

merged 1 commit into from
Jun 4, 2024

Conversation

dingjiayi
Copy link
Contributor

@dingjiayi dingjiayi commented May 30, 2024

Summary

Add port to host header when non-default port is used.The log server receives requests with a host header that does not include the port number

Checklist

Issue reference

Fix #13067

@github-actions github-actions bot added plugins/http-log cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels May 30, 2024
@dingjiayi dingjiayi marked this pull request as ready for review May 30, 2024 11:18
@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label May 30, 2024
@dingjiayi dingjiayi changed the title feat(http-log): add port information to the host header fix(http-log): add port information to the host header May 31, 2024
@dingjiayi
Copy link
Contributor Author

@ADD-SP I kindly request you to review the PR whenever you have a chance.

@ADD-SP ADD-SP self-requested a review May 31, 2024 08:24
@ADD-SP
Copy link
Contributor

ADD-SP commented May 31, 2024

@ADD-SP I kindly request you to review the PR whenever you have a chance.

Sorry for the late reply, I will review this PR later.

@ADD-SP
Copy link
Contributor

ADD-SP commented Jun 3, 2024

Rebased on master

@dingjiayi dingjiayi requested a review from ADD-SP June 3, 2024 10:14
@ADD-SP
Copy link
Contributor

ADD-SP commented Jun 4, 2024

@dingjiayi Thanks for your contribution!

@ADD-SP ADD-SP merged commit 3066f50 into Kong:master Jun 4, 2024
25 checks passed
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@dingjiayi
Copy link
Contributor Author

@ADD-SP Thank you for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/http-log size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-log plugin: Host header not including port
5 participants