-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(http-log): add port information to the host header #13116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plugins/http-log
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
May 30, 2024
3 tasks
team-eng-enablement
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
May 30, 2024
dingjiayi
changed the title
feat(http-log): add port information to the host header
fix(http-log): add port information to the host header
May 31, 2024
@ADD-SP I kindly request you to review the PR whenever you have a chance. |
Sorry for the late reply, I will review this PR later. |
Rebased on master |
ADD-SP
approved these changes
Jun 3, 2024
ADD-SP
approved these changes
Jun 4, 2024
Water-Melon
approved these changes
Jun 4, 2024
@dingjiayi Thanks for your contribution! |
Successfully created cherry-pick PR for |
@ADD-SP Thank you for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author/community
PRs from the open-source community (not Kong Inc)
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/http-log
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add port to host header when non-default port is used.The log server receives requests with a host header that does not include the port number
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #13067