fix(runloop): the sni cache isn't invalidated when a sni is updated #13165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
cherry-pick kong-ee
chronolaw
reviewed
Jun 5, 2024
catbro666
force-pushed
the
fti-6009-sni-cache-invalidate
branch
from
e91931e
to
7ff3071
Compare
chronolaw
approved these changes
Jun 5, 2024
bungle
previously requested changes
Jun 5, 2024
catbro666
force-pushed
the
fti-6009-sni-cache-invalidate
branch
from
7ff3071
to
9c8cd54
Compare
outsinre
approved these changes
Jun 6, 2024
vm-001
reviewed
Jun 12, 2024
Both `data.entity` and `data.old_entity` should be invalidated when a sni is updated. A non-existent sni may also have been cached. https://konghq.atlassian.net/browse/FTI-6009
catbro666
force-pushed
the
fti-6009-sni-cache-invalidate
branch
from
9c8cd54
to
769b031
Compare
vm-001
approved these changes
Jul 2, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13165-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13165-to-master-to-upstream
git checkout -b cherry-pick-13165-to-master-to-upstream
ancref=$(git merge-base 50f5a37a41325f92a367f25bcdf6cd58fd399960 769b031b6ff56265cfbbf36fd7aaf31720d21dcc)
git cherry-pick -x $ancref..769b031b6ff56265cfbbf36fd7aaf31720d21dcc |
github-actions
bot
added
the
incomplete-cherry-pick
|
@catbro666 Please handle cherry-pick manually |
done. |
locao
removed
the
incomplete-cherry-pick
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
…13165) Both `data.entity` and `data.old_entity` should be invalidated when a sni is updated. A non-existent sni may also have been cached. https://konghq.atlassian.net/browse/FTI-6009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Both
data.entityanddata.old_entityshould be invalidated when a sni is updated. A non-existent sni may also have been cached.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
https://konghq.atlassian.net/browse/FTI-6009