fix(correlation-id): auto-complete config.generator when constructing if it is null in database
#13439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/db
schema-change-noteworthy
cherry-pick kong-ee
liverpool8056
force-pushed
the
fix-correlationID-generator-null
branch
2 times, most recently
from
d0452be
to
740a9c9
Compare
ms2008
reviewed
Aug 1, 2024
There was a problem hiding this comment.
nullmeans "don't use the default" in Kong
This is a feature, not a bug. See #9466 (comment) for details.
config.generator=null in database FTI-6134
liverpool8056
force-pushed
the
fix-correlationID-generator-null
branch
from
740a9c9
to
e3356d9
Compare
liverpool8056
changed the title
null in database
ms2008
reviewed
Aug 2, 2024
ms2008
approved these changes
Aug 5, 2024
catbro666
reviewed
Aug 6, 2024
tzssangglass
reviewed
Aug 6, 2024
ms2008
approved these changes
Aug 7, 2024
tzssangglass
approved these changes
Aug 7, 2024
catbro666
approved these changes
Aug 7, 2024
ms2008
reviewed
Aug 7, 2024
changelog/unreleased/kong/fix-correlation-id-config-generator.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Yufu Zhao <[email protected]>
|
Successfully created cherry-pick PR for |
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
… if it is `null` in database (#9886) * fix(correlation-id): make `generator` a required field to prevent it from being set to `null` (#13439) Some fields in the request body to admin api occasionally are specified as `json.null`. In this PR, we add `required=true` to the schema of the field so that it can be auto-completed with the default when construction if it is `null` in database. It will become a mandatory field in KM. (cherry picked from commit 166f465) * add copyright header --------- Co-authored-by: Robin Xiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some fields in the request body to admin api occasionally are specified as
json.null.In this PR, we add
required=trueto the schema of the field so that it can be auto-completed with the default when construction if it isnullin database. It will become a mandatory field in KM.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6134