fix(clustering): hybrid mode should accept special characters used in forward proxy password #13457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… forward proxy password
github-actions
bot
added
core/clustering
cherry-pick kong-ee
changelog/unreleased/kong/fix-clustering-forward-proxy-authentication.yml
Show resolved
Hide resolved
liverpool8056
approved these changes
Aug 9, 2024
catbro666
reviewed
Aug 12, 2024
catbro666
approved these changes
Aug 13, 2024
|
Successfully created cherry-pick PR for |
oowl
pushed a commit
that referenced
this pull request
Aug 15, 2024
… forward proxy password (#13457) Hybrid mode connections not working if the forward proxy password contains special character(`#`). Even after the `proxy_server` is url encoded, it still doesn't work and reports a "407 Proxy Authentication Required" error. This fix tries to address this issue. But, keep in mind that even with this fix, `proxy_server` still needs to be url-encoded. (cherry picked from commit 2c4b98b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hybrid mode connections not working if the forward proxy password contains special character(
#). Even after theproxy_serveris url encoded, it still doesn't work and reports a "407 Proxy Authentication Required" error.This fix tries to address this issue. But, keep in mind that even with this fix,
proxy_serverstill needs to be url-encoded.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6145