Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KTable): loosen types passed to slots in KTable #1299

Merged
merged 8 commits into from
Apr 20, 2023
Merged

fix(KTable): loosen types passed to slots in KTable #1299

merged 8 commits into from
Apr 20, 2023

Conversation

adorack
Copy link
Contributor

@adorack adorack commented Apr 19, 2023 •
edited by adamdehaven
Loading

Summary

Return a typeof any for row and column slot props to prevent having to explicitly typecast in host applications. Also adds a column slot name type interface to properly resolve the slots in the template along with the corresponding slot props.

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@adorack adorack requested a review from a team as a code owner April 19, 2023 13:40
@netlify
Copy link

netlify bot commented Apr 19, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit 72c67bb
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64415973b6c0ac0008220a15
😎 Deploy Preview https://deploy-preview-1299--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adamdehaven adamdehaven enabled auto-merge (squash) April 20, 2023 14:53
kaiarrowood
kaiarrowood approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adamdehaven adamdehaven merged commit 3c7a1bc into main Apr 20, 2023
@adamdehaven adamdehaven deleted the fix/ktable-types branch April 20, 2023 15:31
@kongponents-bot
Copy link
Collaborator

Preview package from this PR in consuming application

In consuming application project install preview version of kongponents generated by this PR:

@kong/kongponents@pr-1299

kongponents-bot pushed a commit that referenced this pull request Apr 20, 2023
@semantic-release-bot
chore(release): 8.53.0 [skip ci]
829b8c2 
# [8.53.0](v8.52.0...v8.53.0) (2023-04-20)

### Bug Fixes

* **KTable:** loosen types passed to slots in KTable ([#1299](#1299)) ([3c7a1bc](3c7a1bc))

### Features

* **KPop, KPrompt, KRadio, KSegmentedControl:** add types [KHCP-6971] ([#1292](#1292)) ([06079a2](06079a2))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kaiarrowood kaiarrowood mentioned this pull request Jun 22, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiarrowood kaiarrowood kaiarrowood approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adorack @kongponents-bot @kaiarrowood @adamdehaven