Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop older TLS support in KIC #1065

Closed
shaneutt opened this issue Mar 3, 2021 · 0 comments · Fixed by #1671
Closed

Drop older TLS support in KIC #1065

shaneutt opened this issue Mar 3, 2021 · 0 comments · Fixed by #1671
Assignees
@shaneutt
Labels
area/security bug Something isn't working priority/low

Comments

@shaneutt
Copy link
Contributor

shaneutt commented Mar 3, 2021

This relates to a comment in a previous PR where gosec lint was disabled in main.go.

We need to make sure we're not accidentally enabling old and deprecated TLS versions.

I believe this problem "just goes away" with Kubebuilder and KIC 2.0 because the defaults there are correct, but I made this issue anyway just to make sure we track and validate that.
@shaneutt shaneutt added bug Something isn't working area/security labels Mar 3, 2021
@shaneutt shaneutt mentioned this issue Mar 3, 2021
Merged
@mflendrich mflendrich removed the pinned label Mar 31, 2021
@shaneutt shaneutt self-assigned this Aug 5, 2021
@shaneutt shaneutt mentioned this issue Aug 5, 2021
Merged
1 task
@shaneutt shaneutt linked a pull request Aug 5, 2021 that will close this issue
fix: support minimum TLS v1.2 for webhook admission server #1671
Merged
1 task
@shaneutt shaneutt closed this as completed Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaneutt shaneutt

Labels
area/security bug Something isn't working priority/low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: support minimum TLS v1.2 for webhook admission server Kong/kubernetes-ingress-controller
2 participants
@mflendrich @shaneutt