-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TLS Passthrough #2041
Conversation
Licenses differ between commit 63f2b68 and base:
|
* Add tests for invalid TCP routes * Add tests for TLS TCP routes
Add an integration test feature to look up a test Kong instance's version via the admin API. Skip the TLS Passthrough test on versions older than 2.7.0.
This reverts commit 760ab66.
Attached are archived runs of integration tests before I reverted the nightly hack and added the version gate. The version gate skips the new integration tests on current versions: logs_20332-pg.zip Enterprise was failing because of #2070 but wasn't of interest because I didn't have an Enterprise nightly to test against. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; I just think that suppressing tests should be opt-in (rather than the default) if obtaining the Kong semver fails. See the attached comment.
Run version-dependent tests regardless if the version is unknown. Add a TEST_KONG_VERSION_OVERRIDE envvar to manually specify the Kong version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A few minor bits, otherwise good to go 👍
What this PR does / why we need it:
Adds support for TLS Passthrough by not doing much of anything. Turns out we already run the route
override()
function on all routes, regardless of what kind of Ingress-like they came from, so editing the allowed protocols string and slapping akonghq.com/protocols
annotation on a TCPIngress is sufficient.This mostly adds tests:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #2023fixes #1179
Special notes for your reviewer:
This is a draft because Kong 2.7 is not yet released, and current versions of Kong do not accept the
tls_passthrough
protocol. It includes a temporary commit to use a nightly and use a modified version of go-kong that doesn't break on nightly release version strings. Once 2.7 is released, we can remove this.This will also require a new release of KTF that includes Kong/kubernetes-testing-framework@276b0c6
passthrough_test.txt shows a single test run.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR