Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--kong-custom-entities-secret flag has no effect #3278

Closed
1 task
pmalek opened this issue Dec 19, 2022 · 0 comments · Fixed by #3262
Closed
1 task

--kong-custom-entities-secret flag has no effect #3278

pmalek opened this issue Dec 19, 2022 · 0 comments · Fixed by #3262
Assignees
@pmalek
Labels
bug Something isn't working
Milestone
KIC v2.9.0

Comments

@pmalek
Copy link
Member

pmalek commented Dec 19, 2022

Problem statement

It seems that --kong-custom-entities-secret flag has no effect as of dd49dfd and it never had since v2.0.0.

This issue tracks the effort and discussion around it to either fix this situation and restore the functionality or remove the relevant pieces of code and the flag.

Acceptance criteria

  • --kong-custom-entities-secret flag and code relevant for processing custom entities is removed or the functionality is restored as it used to work pre v2 and an appropriate test is added
@pmalek pmalek added the bug Something isn't working label Dec 19, 2022
@pmalek pmalek mentioned this issue Dec 19, 2022
Merged
@pmalek pmalek self-assigned this Jan 5, 2023
@pmalek pmalek added this to the KIC v2.9.0 milestone Jan 5, 2023
@pmalek pmalek linked a pull request Jan 9, 2023 that will close this issue
refactor: delete custom entities #3262
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmalek pmalek

Labels
bug Something isn't working
Projects
None yet
Milestone
KIC v2.9.0
Development

Successfully merging a pull request may close this issue.

refactor: delete custom entities Kong/kubernetes-ingress-controller
1 participant
@pmalek