Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that tests for single controller deployments exist #3429

Closed
5 tasks done
Tracked by #702
mflendrich opened this issue Jan 24, 2023 · 2 comments
Closed
5 tasks done
Tracked by #702

Ensure that tests for single controller deployments exist #3429

mflendrich opened this issue Jan 24, 2023 · 2 comments
Assignees
Milestone

Comments

@mflendrich
Copy link
Contributor

mflendrich commented Jan 24, 2023

With #702 being implemented and #3421 merged we'd like to ensure that we have sufficient test coverage for Single Controller Deployments.

Acceptance Criteria

@mflendrich
Copy link
Contributor Author

closed in favor of #3568

@czeslavo
Copy link
Contributor

czeslavo commented Mar 1, 2023

Reopening this after realizing there's more than just one test to be added before the release. Let this issue serve us as the one that when closed means SCD is covered sufficiently in tests.

I made a comment in #3631 that might be helpful in understanding rationale behind tests I put into the AC of this issue.

Can we agree that everything included in this issue's ACs is enough to consider SCD ready for release? @pmalek @mflendrich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants