Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate KongUpstreamPolicy status for every attached object in the controller #4932

Closed
1 task
Tracked by #5291
czeslavo opened this issue Oct 20, 2023 · 1 comment · Fixed by #5185
Closed
1 task
Tracked by #5291

Populate KongUpstreamPolicy status for every attached object in the controller #4932

czeslavo opened this issue Oct 20, 2023 · 1 comment · Fixed by #5185
Assignees
Labels
area/feature New feature or request
Milestone

Comments

@czeslavo
Copy link
Contributor

czeslavo commented Oct 20, 2023

Problem Statement

When KongUpstreamPolicy is attached to an object (Service or GW API *Route) using the konghq.com/upstream-policy, the controller should populate its status accordingly:

  • When Service is annotated and used in GW API rule with multiple backend refs, but their konghq.com/upstream-policy annotations do not match, status.ancestors is populated with Accepted condition with status Conflicted
  • The condition Accepted is set with Value "True" and Reason=Accepted if Service is annotated and the above condition does not happen

Ensure that envtests covering the controller are added that will mock successful config update and will ensure that conditions are properly populated.

Proposed solution

A new controller watches KongUpstreamPolicy, Service, and *Routes and set the KongUpstreamPolicy status according to the above rules.

Acceptance criteria

  • status.ancestors slice is populated with one entry per each KongUpstreamPolicy-associated object
@czeslavo
Copy link
Contributor Author

Moving to KIC v3.1.0 milestone as we decided to not implement status in 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants