Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhook): do not require rsa_public_key field in credentials secrets when working with jwt HMAC algorigthms #5737

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Mar 21, 2024

What this PR does / why we need it:

Do not requiere the rsa_public_key field in credential secrets when working with jwt HMAC credentials.

The algorithm values are compares against https://docs.konghq.com/hub/kong-inc/jwt-signer/configuration/#config-enable_hs_signatures

Which issue this PR fixes:

Fixes #5736

Related: #5159

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pmalek pmalek self-assigned this Mar 21, 2024
@pmalek pmalek force-pushed the do-not-require-rsa-public-key-for-hmac-algo branch from 0174196 to b195a9c Compare March 21, 2024 13:23
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.7%. Comparing base (8c49b29) to head (b195a9c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5737     +/-   ##
=======================================
- Coverage   71.7%   71.7%   -0.1%     
=======================================
  Files        175     175             
  Lines      18141   18147      +6     
=======================================
- Hits       13019   13014      -5     
- Misses      4170    4185     +15     
+ Partials     952     948      -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@randmonkey randmonkey merged commit c9978fa into main Mar 25, 2024
39 checks passed
@randmonkey randmonkey deleted the do-not-require-rsa-public-key-for-hmac-algo branch March 25, 2024 07:27
@pmalek pmalek added this to the KIC v3.2.x milestone Mar 27, 2024
@randmonkey randmonkey mentioned this pull request Apr 2, 2024
29 tasks
@team-k8s-bot
Copy link
Collaborator

The backport to release/3.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-5737-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c9978fabd5f82275db1cd0135608d8b7d7351891
# Push it to GitHub
git push --set-upstream origin backport-5737-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x

Then, create a pull request where the base branch is release/3.1.x and the compare/head branch is backport-5737-to-release/3.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants