-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webhook): do not require rsa_public_key field in credentials secrets when working with jwt HMAC algorigthms #5737
Conversation
…ets when working with jwt HMAC algorigthms
0174196
to
b195a9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5737 +/- ##
=======================================
- Coverage 71.7% 71.7% -0.1%
=======================================
Files 175 175
Lines 18141 18147 +6
=======================================
- Hits 13019 13014 -5
- Misses 4170 4185 +15
+ Partials 952 948 -4 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-5737-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c9978fabd5f82275db1cd0135608d8b7d7351891
# Push it to GitHub
git push --set-upstream origin backport-5737-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x Then, create a pull request where the |
…ets when working with jwt HMAC algorigthms (#5737)
What this PR does / why we need it:
Do not requiere the
rsa_public_key
field in credential secrets when working with jwt HMAC credentials.The
algorithm
values are compares against https://docs.konghq.com/hub/kong-inc/jwt-signer/configuration/#config-enable_hs_signaturesWhich issue this PR fixes:
Fixes #5736
Related: #5159
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR