Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(entities-plugins, vfg): create plugin form a11y improvements [KHCP-11026] #1272

Merged
merged 13 commits into from
Mar 25, 2024

Conversation

portikM
Copy link
Member

@portikM portikM commented Mar 20, 2024

Summary

Addresses: https://konghq.atlassian.net/browse/KHCP-11026

Create new plugin form changes/fixes:

  • scoped fields (Service ID and Route ID) labels should be associated to the input fields
  • all labels with tooltips should have aria-describedby attribute containing id of tooltip element
  • each input element in array fields (e.g. Allow, Deny fields in ACL plugin form or Exposed Headers in CORS plugin form) should have aria-labelledby attribute pointing at the array field label
  • filterable KSelect and KMultiselect dropdown elements should have aria-live="polite" attribute set on element wrapping the items or empty state (screenshot)

Screenshot 2024-03-21 at 1 45 46 PM

Resources

@portikM portikM self-assigned this Mar 20, 2024
@portikM portikM marked this pull request as ready for review March 21, 2024 17:36
sumimakito
sumimakito previously approved these changes Mar 22, 2024
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The VFG changes LGTM

@portikM portikM enabled auto-merge (squash) March 22, 2024 02:03
ValeryG
ValeryG previously approved these changes Mar 22, 2024
@portikM portikM dismissed stale reviews from ValeryG and sumimakito via a667b6e March 25, 2024 13:17
@portikM portikM merged commit b1ed04e into main Mar 25, 2024
31 checks passed
@portikM portikM deleted the fix/khcp-11026-create-plugin-a11y branch March 25, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants